Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753880AbYLHMy7 (ORCPT ); Mon, 8 Dec 2008 07:54:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751952AbYLHMyr (ORCPT ); Mon, 8 Dec 2008 07:54:47 -0500 Received: from nelson.telenet-ops.be ([195.130.133.66]:48933 "EHLO nelson.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752030AbYLHMyq (ORCPT ); Mon, 8 Dec 2008 07:54:46 -0500 Date: Mon, 8 Dec 2008 13:54:42 +0100 (CET) From: Geert Uytterhoeven To: Kay Sievers cc: Mark Jackson , Linux Kernel Development , Haavard Skinnemoen , Andrew Morton , Peter Zijlstra , David Woodhouse , Linux/m68k Subject: Re: Badness at mm/backing-dev.c:179 In-Reply-To: Message-ID: References: <49367691.5060007@mimc.co.uk> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2050 Lines: 49 On Mon, 8 Dec 2008, Kay Sievers wrote: > On Mon, Dec 8, 2008 at 09:16, Geert Uytterhoeven wrote: > > On Wed, 3 Dec 2008, Kay Sievers wrote: > >> On Wed, Dec 3, 2008 at 13:07, Mark Jackson wrote: > >> > The following commit causes a "Badness at mm/backing-dev.c:179":- > >> > > >> > f1d0b063d993527754f062c589b73f125024d216 is first bad commit > >> > commit f1d0b063d993527754f062c589b73f125024d216 > >> > Author: Kay Sievers > >> > Date: Tue Dec 2 10:31:50 2008 -0800 > >> > > >> > bdi: register sysfs bdi device only once per queue > >> > >> > Below is the extract from dmesg:- > >> > > >> > ------------[ cut here ]------------ > >> > Badness at mm/backing-dev.c:179 > >> > >> That's a known issue, and will not cause any harm besides printing > >> this warning. Andrew added the warning to catch drivers who use one > >> single request queue for multiple devices. Currently known are mtd and > >> floppy (triggers only if you have more than one device per driver). > >> The drivers need to be changed to use a separate queue per device, to > >> get rid of this warning. > > > > I guess this one (introduced after 2.6.28-rc7) is an incarnation of the same > > issue? > > You have more than one floppy device registered at the same time, > right? Then it's very likely the same issue, that both devices share > the same request queue, like the x86 floppy.c. Yep, ataflop.c (and amiflop.c) forked from floppy.c a long time ago... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/