Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754069AbYLIEDu (ORCPT ); Mon, 8 Dec 2008 23:03:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751559AbYLIEDl (ORCPT ); Mon, 8 Dec 2008 23:03:41 -0500 Received: from e28smtp04.in.ibm.com ([59.145.155.4]:40701 "EHLO e28smtp04.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751527AbYLIEDk (ORCPT ); Mon, 8 Dec 2008 23:03:40 -0500 Date: Tue, 9 Dec 2008 09:37:06 +0530 From: Vaidyanathan Srinivasan To: Ingo Molnar Cc: Linux Kernel , Gautham R Shenoy , Peter Zijlstra Subject: Re: [BUG] idle_balance() does not call load_balance_newidle() Message-ID: <20081209040706.GA20525@dirshya.in.ibm.com> Reply-To: svaidy@linux.vnet.ibm.com Mail-Followup-To: Ingo Molnar , Linux Kernel , Gautham R Shenoy , Peter Zijlstra References: <20081208152249.GI5457@dirshya.in.ibm.com> <20081208154939.GA405@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20081208154939.GA405@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1147 Lines: 31 * Ingo Molnar [2008-12-08 16:49:39]: > > * Vaidyanathan Srinivasan wrote: > > > Hi, > > > > load_balance_newidle() does not get called if SD_BALANCE_NEWIDLE is > > set at higher level domain (3-CPU) and not in low level domain (2-MC). > > > > pulled_task is initialised to -1 and checked for non-zero which is > > always true if the lowest level sched_domain does not have > > SD_BALANCE_NEWIDLE flag set. > > > > Trivial fix to initialise pulled_task to zero. > > Patch against 2.6.28-rc7 > > applied to tip/sched/core, thanks! (Not for v2.6.28 because this could > affect performance.) Thanks Ingo. This patch does not change any functionality in v2.6.28 and hence will not affect performance. The SD flags are not touched. I found this bug while setting different SD flags at MC level and CPU level in my power saving balance patches. --Vaidy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/