Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754137AbYLINQX (ORCPT ); Tue, 9 Dec 2008 08:16:23 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752815AbYLINQL (ORCPT ); Tue, 9 Dec 2008 08:16:11 -0500 Received: from smtp.nokia.com ([192.100.105.134]:29892 "EHLO mgw-mx09.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752766AbYLINQJ (ORCPT ); Tue, 9 Dec 2008 08:16:09 -0500 Date: Tue, 9 Dec 2008 15:17:05 +0200 From: Lauri Leukkunen To: ext Sam Ravnborg Cc: Trilok Soni , David Brownell , dmitry.torokhov@gmail.com, "linux-omap@vger.kernel.org Mailing List" , linux-kernel@vger.kernel.org, spi-devel-general@lists.sourceforge.net, linux-input@vger.kernel.org Subject: Re: [PATCH] Add TI TSC2005 Touchscreen driver Message-ID: <20081209131705.GC6667@pure.research.nokia.com> References: <5d5443650812080949h5aff6010mb7341f581841f126@mail.gmail.com> <20081208182648.GA9740@uranus.ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081208182648.GA9740@uranus.ravnborg.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-OriginalArrivalTime: 09 Dec 2008 13:15:35.0621 (UTC) FILETIME=[38CCB750:01C95A00] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 795 Lines: 22 On 08/12/08 19:26 +0100, ext Sam Ravnborg wrote: > > Add Texas Instruments TSC2005 chip touchscreen driver. > > > > Signed-off-by: Trilok Soni > > Hi Trilok. > A few nitpicks below. > > In general a very clean written driver with adequate comments - nice work! Umm, isn't this code mostly written by Nokia? At least I remember modifying some of it, and this version looks like Konsta Karsisto might be the last person touching it. Originally I think it's written by Imre Deak, probably based on the tsc2301 code. /lauri -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/