Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755151AbYLITE3 (ORCPT ); Tue, 9 Dec 2008 14:04:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754160AbYLITEU (ORCPT ); Tue, 9 Dec 2008 14:04:20 -0500 Received: from zone0.gcu-squad.org ([212.85.147.21]:25161 "EHLO services.gcu-squad.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753731AbYLITEU (ORCPT ); Tue, 9 Dec 2008 14:04:20 -0500 Date: Tue, 9 Dec 2008 20:04:09 +0100 From: Jean Delvare To: Roel Kluin Cc: linux-i2c@vger.kernel.org, lkml Subject: Re: [PATCH 12/33] i2c: Make static Message-ID: <20081209200409.17fac29f@hyperion.delvare> In-Reply-To: <493EBBD0.6070201@gmail.com> References: <493EA286.7080500@gmail.com> <493EBBD0.6070201@gmail.com> X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.9; x86_64-suse-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1181 Lines: 34 On Tue, 09 Dec 2008 19:41:20 +0100, Roel Kluin wrote: > Sparse asked whether these could be static. > > Signed-off-by: Roel Kluin > --- > drivers/i2c/i2c-core.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c > index c6a63f4..1049615 100644 > --- a/drivers/i2c/i2c-core.c > +++ b/drivers/i2c/i2c-core.c > @@ -1699,7 +1699,8 @@ EXPORT_SYMBOL(i2c_smbus_write_word_data); > * This executes the SMBus "process call" protocol, returning negative errno > * else a 16-bit unsigned "word" received from the device. > */ > -s32 i2c_smbus_process_call(struct i2c_client *client, u8 command, u16 value) > +static s32 i2c_smbus_process_call(struct i2c_client *client, u8 command, > + u16 value) > { > union i2c_smbus_data data; > int status; Nack: drivers/i2c/i2c-core.c:EXPORT_SYMBOL(i2c_smbus_process_call); -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/