Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755474AbYLJCPJ (ORCPT ); Tue, 9 Dec 2008 21:15:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753582AbYLJCO6 (ORCPT ); Tue, 9 Dec 2008 21:14:58 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.124]:36927 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753391AbYLJCO5 (ORCPT ); Tue, 9 Dec 2008 21:14:57 -0500 Date: Tue, 9 Dec 2008 21:14:54 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Frederic Weisbecker cc: Ingo Molnar , Peter Zijlstra , LKML Subject: Re: [PATCH 0/3] tracing/function-graph-tracer: signal interrupt triggering on output In-Reply-To: <493EF64D.50804@gmail.com> Message-ID: References: <493EF64D.50804@gmail.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1226 Lines: 37 On Tue, 9 Dec 2008, Frederic Weisbecker wrote: > This patchset adds all the features to draw hardirq triggering on output > for the function graph tracer. > An example is given on the third patch. > > Just one question, on recordmcount.pl: > > my %text_sections = ( > ".text" => 1, > ".sched.text" => 1, > ".spinlock.text" => 1, > > The .sched.text section is included inside .text, it's a subsection, I'm not sure > it's necessary to add it in text_sections. In doubt I added the new .irqentry.text > Matters what objdump -dr shows. $ objdump -dr kernel/sched.o | grep 'Disassembly' Disassembly of section .text: Disassembly of section .cpuinit.text: Disassembly of section .init.text: Disassembly of section .sched.text: Yep, .sched.text is needed. It is not about what gets linked by the linker. It is about what objdump shows, which is what recordmcount.pl uses to determine whether or not to record the mcount callers in that section. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/