Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754826AbYLJSZf (ORCPT ); Wed, 10 Dec 2008 13:25:35 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752378AbYLJSZZ (ORCPT ); Wed, 10 Dec 2008 13:25:25 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:49980 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751382AbYLJSZY (ORCPT ); Wed, 10 Dec 2008 13:25:24 -0500 Subject: Re: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU From: David Woodhouse To: Joerg Roedel Cc: Avi Kivity , mingo@redhat.com, weidong.han@intel.com, torvalds@linux-foundation.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org In-Reply-To: <20081210142525.GC12816@amd.com> References: <20081209141143.GW12816@amd.com> <493F8D90.40205@redhat.com> <20081210141131.GB12816@amd.com> <1228918928.21454.27.camel@macbook.infradead.org> <20081210142525.GC12816@amd.com> Content-Type: text/plain Date: Wed, 10 Dec 2008 18:24:35 +0000 Message-Id: <1228933475.23842.70.camel@macbook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 (2.24.2-1.fc10) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1223 Lines: 31 On Wed, 2008-12-10 at 15:25 +0100, Joerg Roedel wrote: > I already did it on-top of your tree because Han Weidong's patches 1-17 > were rebased to your tree and my IOMMU-API patches apply on-top of his > patches. OK, thanks. Looks like you still need this though, as Mike Day pointed out: diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c index 97df47c..a5f6e28 100644 --- a/drivers/pci/intel-iommu.c +++ b/drivers/pci/intel-iommu.c @@ -204,7 +204,7 @@ static inline bool dma_pte_present(struct dma_pte *pte) } /* devices under the same p2p bridge are owned in one domain */ -#define DOMAIN_FLAG_P2P_MULTIPLE_DEVICES (1 < 0) +#define DOMAIN_FLAG_P2P_MULTIPLE_DEVICES (1 << 0) /* domain represents a virtual machine, more than one devices * across iommus may be owned in one domain, e.g. kvm guest. -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/