Date: Wed, 10 Dec 2008 19:42:40 +0100
From: Joerg Roedel <joerg.roedel@amd.com>
To: David Woodhouse <dwmw2@infradead.org>
CC: Avi Kivity <avi@redhat.com>, mingo@redhat.com, weidong.han@intel.com,
       torvalds@linux-foundation.org, iommu@lists.linux-foundation.org,
       linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCHSETS #2] KVM device passthrough support with AMD IOMMU
Message-ID: <20081210184240.GH12816@amd.com>
References: <20081209141143.GW12816@amd.com> <493F8D90.40205@redhat.com> <20081210141131.GB12816@amd.com> <1228918928.21454.27.camel@macbook.infradead.org> <20081210142525.GC12816@amd.com> <1228933475.23842.70.camel@macbook.infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1228933475.23842.70.camel@macbook.infradead.org>
User-Agent: mutt-ng/devel-r804 (Linux)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1656
Lines: 38

On Wed, Dec 10, 2008 at 06:24:35PM +0000, David Woodhouse wrote:
> On Wed, 2008-12-10 at 15:25 +0100, Joerg Roedel wrote:
> > I already did it on-top of your tree because Han Weidong's patches 1-17
> > were rebased to your tree and my IOMMU-API patches apply on-top of his
> > patches.
> 
> OK, thanks. Looks like you still need this though, as Mike Day pointed
> out:
> 
> diff --git a/drivers/pci/intel-iommu.c b/drivers/pci/intel-iommu.c
> index 97df47c..a5f6e28 100644
> --- a/drivers/pci/intel-iommu.c
> +++ b/drivers/pci/intel-iommu.c
> @@ -204,7 +204,7 @@ static inline bool dma_pte_present(struct dma_pte *pte)
>  }
>  
>  /* devices under the same p2p bridge are owned in one domain */
> -#define DOMAIN_FLAG_P2P_MULTIPLE_DEVICES (1 < 0)
> +#define DOMAIN_FLAG_P2P_MULTIPLE_DEVICES (1 << 0)
>  
>  /* domain represents a virtual machine, more than one devices
>   * across iommus may be owned in one domain, e.g. kvm guest.

Ok, I add it, thanks. Who is the author, Mike or you?

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/