Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756857AbYLJTBh (ORCPT ); Wed, 10 Dec 2008 14:01:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755576AbYLJTAt (ORCPT ); Wed, 10 Dec 2008 14:00:49 -0500 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.125]:64861 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756863AbYLJTAr (ORCPT ); Wed, 10 Dec 2008 14:00:47 -0500 Date: Wed, 10 Dec 2008 14:00:44 -0500 (EST) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Eric Dumazet cc: LKML , Ingo Molnar , Linus Torvalds , Andrew Morton , Arnaldo Carvalho de Melo , "David S. Miller" , Linux Netdev List Subject: Re: [PATCH] replace deprecated RW_LOCK_UNLOCKED in net/dccp/proto.c In-Reply-To: <49400B7F.7040607@cosmosbay.com> Message-ID: References: <49400B7F.7040607@cosmosbay.com> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1131 Lines: 37 On Wed, 10 Dec 2008, Eric Dumazet wrote: > cced netdev Thanks, > > Steven Rostedt a ?crit : > > > > struct inet_hashinfo __cacheline_aligned dccp_hashinfo = { > > - .lhash_lock = RW_LOCK_UNLOCKED, > > + .lhash_lock = __RW_LOCK_UNLOCKED(dccp_hashinfo.lhash_lock), > > .lhash_users = ATOMIC_INIT(0), > > .lhash_wait = __WAIT_QUEUE_HEAD_INITIALIZER(dccp_hashinfo.lhash_wait), > > }; > > -- > > Hum... this rwlock doesnt exist anymore on net-next-2.6, all this stuff > was converted to RCU for upcoming 2.6.29 > > struct inet_hashinfo dccp_hashinfo; > EXPORT_SYMBOL_GPL(dccp_hashinfo); > > I guess such a patch wont ease David job when 2.6.29 merge window opens One of the requirements in the new rt git tree is that all rwlocks must use the __RW_LOCK_UNLOCK(lock) macro. I had to fix it in our tree, but whenever I do a clean up patch, I like to share it ;-) -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/