Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756329AbYLJTLE (ORCPT ); Wed, 10 Dec 2008 14:11:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753475AbYLJTKw (ORCPT ); Wed, 10 Dec 2008 14:10:52 -0500 Received: from pfepa.post.tele.dk ([195.41.46.235]:39976 "EHLO pfepa.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697AbYLJTKv (ORCPT ); Wed, 10 Dec 2008 14:10:51 -0500 Date: Wed, 10 Dec 2008 20:12:13 +0100 From: Sam Ravnborg To: Vladislav Bolkhovitin Cc: linux-scsi@vger.kernel.org, James Bottomley , Andrew Morton , FUJITA Tomonori , Mike Christie , Jeff Garzik , Boaz Harrosh , Linus Torvalds , linux-kernel@vger.kernel.org, scst-devel@lists.sourceforge.net, Bart Van Assche , "Nicholas A. Bellinger" Subject: Re: [PATCH][RFC 2/23]: SCST core Message-ID: <20081210191213.GA15273@uranus.ravnborg.org> References: <494009D7.4020602@vlnb.net> <49400ACD.3070502@vlnb.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49400ACD.3070502@vlnb.net> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1501 Lines: 44 On Wed, Dec 10, 2008 at 09:30:37PM +0300, Vladislav Bolkhovitin wrote: > This patch contains SCST core code. > > Signed-off-by: Vladislav Bolkhovitin > --- > drivers/scst/Kconfig | 256 ++ Do not use "default n" - this is already the default value. > drivers/scst/Makefile | 12 EXTRA_CFLAGS are deprecated in favour of ccflags-y > drivers/scst/scst_cdbprobe.h | 519 +++++ static const struct scst_sdbops scst_scsi_op_table[] This does not belong to a header file. > drivers/scst/scst_lib.c | 3689 +++++++++++++++++++++++++++++++++++++ > drivers/scst/scst_main.c | 1919 +++++++++++++++++++ > drivers/scst/scst_module.c | 69 > drivers/scst/scst_priv.h | 513 +++++ > drivers/scst/scst_targ.c | 5458 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 8 files changed, 12435 insertions(+) There was a lot af TRACE_ENTRY() / TRACE_EXIT() noise. We should have proper tools for that by now (I hope). We often ask for exported symbols to be documented - so one has a slight idea of their purpose. CONFIG_SCST_STRICT_SERIALIZING has bad impact on readability. Could this be abstracted better? I did not look into the source in details. Just a few sparse comments. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/