Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755272AbYLJWSy (ORCPT ); Wed, 10 Dec 2008 17:18:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752501AbYLJWSo (ORCPT ); Wed, 10 Dec 2008 17:18:44 -0500 Received: from smtp.movial.fi ([62.236.91.34]:46388 "EHLO smtp.movial.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752378AbYLJWSn (ORCPT ); Wed, 10 Dec 2008 17:18:43 -0500 Message-ID: <53806.88.114.236.15.1228947522.squirrel@webmail.movial.fi> In-Reply-To: <8bd0f97a0812100928l2c75d373n7eba5aa0cc3882fd@mail.gmail.com> References: <8bd0f97a0812100928l2c75d373n7eba5aa0cc3882fd@mail.gmail.com> Date: Thu, 11 Dec 2008 00:18:42 +0200 (EET) Subject: Re: [PATCH 1/28] drivers/base/platform.c: Drop return value from platform_driver remove functions From: "Vorobiev Dmitri" To: "Mike Frysinger" Cc: "Julia Lawall" , dmitri.vorobiev@movial.fi, gregkh@suse.de, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org User-Agent: SquirrelMail/1.4.9a MIME-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: 8bit X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 34 > On Wed, Dec 10, 2008 at 11:26, Julia Lawall wrote: >> The return value of the remove function of a driver structure, and thus >> of >> a platform_driver structure, is ultimately ignored, and is thus >> unnecessary. The goal of this patch is to make it possible to convert >> the >> platform_driver functions stored in the remove field such that they >> return >> void. This patch introduces a temporary field remove_new with return >> type >> void into the platform_driver structure, and updates the only place that >> the remove function is called to call the function in the remove_new >> field, >> if one is available. The subsequent patches update some drivers to use >> the >> remove_new field. > > why bother with remove -> remove_new convention ? Please see this email for the background: http://lkml.org/lkml/2008/12/10/231 > you'll get a > warning in C about the assignment, but you wont get a build failure, ...unless you compile with -Werror, which frequently the case. Dmitri -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/