Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756102AbYLKJGO (ORCPT ); Thu, 11 Dec 2008 04:06:14 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754379AbYLKJFz (ORCPT ); Thu, 11 Dec 2008 04:05:55 -0500 Received: from mtagate8.uk.ibm.com ([195.212.29.141]:65102 "EHLO mtagate8.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753869AbYLKJFx (ORCPT ); Thu, 11 Dec 2008 04:05:53 -0500 From: Christian Borntraeger To: Mark McLoughlin Subject: Re: [PATCH 5/6] kvm-s390: use register_virtio_root_device() Date: Thu, 11 Dec 2008 10:05:49 +0100 User-Agent: KMail/1.9.9 Cc: Rusty Russell , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Anthony Liguori , Kay Sievers , Greg KH , Cornelia Huck References: <1228931096.5384.63.camel@blaa> <1228931139-12956-4-git-send-email-markmc@redhat.com> <1228931139-12956-5-git-send-email-markmc@redhat.com> In-Reply-To: <1228931139-12956-5-git-send-email-markmc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200812111005.49597.borntraeger@de.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 939 Lines: 24 Am Mittwoch, 10. Dezember 2008 schrieb Mark McLoughlin: > This is basically a no-op change, since it does exactly the > same thing as s390_root_dev_register() when the caller isn't > a module. Ok, I gave it a short test and it seems to work. Some comments: I agree with your comment in patch0, that a generic device_register_root() function might be useful. > --- a/drivers/s390/kvm/kvm_virtio.c > +++ b/drivers/s390/kvm/kvm_virtio.c [...] > - kvm_root = s390_root_dev_register("kvm_s390"); > + kvm_root = register_virtio_root_device("kvm_s390"); [...] > - s390_root_dev_unregister(kvm_root); > + unregister_virtio_root_device(kvm_root); You can now remove the include -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/