Date: Thu, 11 Dec 2008 11:58:44 +0100
From: Jean Delvare <khali@linux-fr.org>
To: Jens Axboe <jens.axboe@oracle.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: Fix LSF default inconsistency
Message-ID: <20081211115844.1b1dbf49@hyperion.delvare>
In-Reply-To: <20081211104109.GF23742@kernel.dk>
References: <20081211111614.493d2a62@hyperion.delvare>
	<20081211104109.GF23742@kernel.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1138
Lines: 28

On Thu, 11 Dec 2008 11:41:10 +0100, Jens Axboe wrote:
> On Thu, Dec 11 2008, Jean Delvare wrote:
> > Configuration option LSF has a default which contradicts its help
> > text. The help text says "if unsure, say Y" but there is no explicit
> > default, and the default default is N.
> > 
> > This inconsistency was introduced by commit
> > 88b9adb073b7a69a54b1b14423103bc24587ebdc. According to the commit
> > message, we want users to enable this option, so it should default to
> > Y.
> 
> I wonder if we just shouldn't get rid of this option and just have the
> single CONFIG_LBD option control both of these. If you set CONFIG_LBD,
> you probably want large files as well. And CONFIG_LSF without CONFIG_LBD
> doesn't make a lot of sense.
> 
> Would anyone object to such a change?

No objection from me, getting rid of configuration options almost
always gets my vote :)

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/