Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756860AbYLKTRU (ORCPT ); Thu, 11 Dec 2008 14:17:20 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757124AbYLKTQv (ORCPT ); Thu, 11 Dec 2008 14:16:51 -0500 Received: from kumera.dghda.com ([80.68.90.171]:39576 "EHLO kumera.dghda.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756955AbYLKTQu (ORCPT ); Thu, 11 Dec 2008 14:16:50 -0500 From: "Duane Griffin" To: linux-kernel@vger.kernel.org Cc: linux-fsdevel@vger.kernel.org, Boaz Harrosh , Duane Griffin , linux-ext4@vger.kernel.org Subject: [PATCH] ext2: ensure link targets are NULL-terminated Date: Thu, 11 Dec 2008 19:16:28 +0000 Message-Id: <1229022995-9898-5-git-send-email-duaneg@dghda.com> X-Mailer: git-send-email 1.6.0.4 In-Reply-To: <1229022995-9898-4-git-send-email-duaneg@dghda.com> References: <1229022995-9898-1-git-send-email-duaneg@dghda.com> <1229022995-9898-2-git-send-email-duaneg@dghda.com> <1229022995-9898-3-git-send-email-duaneg@dghda.com> <1229022995-9898-4-git-send-email-duaneg@dghda.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 902 Lines: 30 Ensure link targets are NULL-terminated, even if corrupted on-disk. Signed-off-by: Duane Griffin --- fs/ext2/symlink.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/fs/ext2/symlink.c b/fs/ext2/symlink.c index 4e2426e..9b164ba 100644 --- a/fs/ext2/symlink.c +++ b/fs/ext2/symlink.c @@ -24,7 +24,9 @@ static void *ext2_follow_link(struct dentry *dentry, struct nameidata *nd) { struct ext2_inode_info *ei = EXT2_I(dentry->d_inode); - nd_set_link(nd, (char *)ei->i_data); + char *link = (char *) ei->i_data; + link[sizeof(ei->i_data) - 1] = '\0'; + nd_set_link(nd, link); return NULL; } -- 1.6.0.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/