Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758606AbYLKTtp (ORCPT ); Thu, 11 Dec 2008 14:49:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758501AbYLKT11 (ORCPT ); Thu, 11 Dec 2008 14:27:27 -0500 Received: from g5t0009.atlanta.hp.com ([15.192.0.46]:12491 "EHLO g5t0009.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758884AbYLKT10 (ORCPT ); Thu, 11 Dec 2008 14:27:26 -0500 Date: Thu, 11 Dec 2008 12:27:25 -0700 From: Alex Chiang To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Jesse Barnes , justin.chen@hp.com, linux-pci , linux-kernel Subject: Re: [PATCH 1/2] PCI Hotplug: acpiphp wants a 64-bit _SUN Message-ID: <20081211192725.GH18309@ldl.fc.hp.com> Mail-Followup-To: Alex Chiang , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Jesse Barnes , justin.chen@hp.com, linux-pci , linux-kernel References: <20081211181242.GD18309@ldl.fc.hp.com> <20081211181644.GE18309@ldl.fc.hp.com> <20081211192356.GS31176@sci.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20081211192356.GS31176@sci.fi> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1349 Lines: 39 * Ville Syrj?l? : > On Thu, Dec 11, 2008 at 11:16:44AM -0700, Alex Chiang wrote: > > From: Justin Chen > > > > Certain HP machines require the full 64 bits of _SUN as allowed > > by the ACPI spec. Without this change, we get name collisions in > > the lower 32 bits of the _SUN returned by firmware. > > > > Signed-off-by: Justin Chen > > Signed-off-by: Alex Chiang > > --- > > diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h > > index f9e244d..9bcb6cb 100644 > > --- a/drivers/pci/hotplug/acpiphp.h > > +++ b/drivers/pci/hotplug/acpiphp.h > > @@ -113,7 +113,7 @@ struct acpiphp_slot { > > > > u8 device; /* pci device# */ > > > > - u32 sun; /* ACPI _SUN (slot unique number) */ > > + unsigned long long sun; /* ACPI _SUN (slot unique number) */ > > Why not make it u64 if that's what ACPI says it should be? Some 64-bit architectures typedef u64 to unsigned long, and some to unsigned long long. I'd prefer not to have to cast it to a (ULL) every time I want to printk. Thanks. /ac -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/