Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758145AbYLKTz4 (ORCPT ); Thu, 11 Dec 2008 14:55:56 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756227AbYLKTzq (ORCPT ); Thu, 11 Dec 2008 14:55:46 -0500 Received: from smtp4.pp.htv.fi ([213.243.153.38]:36568 "EHLO smtp4.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756673AbYLKTzp (ORCPT ); Thu, 11 Dec 2008 14:55:45 -0500 X-Greylist: delayed 1905 seconds by postgrey-1.27 at vger.kernel.org; Thu, 11 Dec 2008 14:55:45 EST Date: Thu, 11 Dec 2008 21:23:56 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Alex Chiang , Jesse Barnes , justin.chen@hp.com, linux-pci , linux-kernel Subject: Re: [PATCH 1/2] PCI Hotplug: acpiphp wants a 64-bit _SUN Message-ID: <20081211192356.GS31176@sci.fi> Mail-Followup-To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Alex Chiang , Jesse Barnes , justin.chen@hp.com, linux-pci , linux-kernel References: <20081211181242.GD18309@ldl.fc.hp.com> <20081211181644.GE18309@ldl.fc.hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20081211181644.GE18309@ldl.fc.hp.com> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 32 On Thu, Dec 11, 2008 at 11:16:44AM -0700, Alex Chiang wrote: > From: Justin Chen > > Certain HP machines require the full 64 bits of _SUN as allowed > by the ACPI spec. Without this change, we get name collisions in > the lower 32 bits of the _SUN returned by firmware. > > Signed-off-by: Justin Chen > Signed-off-by: Alex Chiang > --- > diff --git a/drivers/pci/hotplug/acpiphp.h b/drivers/pci/hotplug/acpiphp.h > index f9e244d..9bcb6cb 100644 > --- a/drivers/pci/hotplug/acpiphp.h > +++ b/drivers/pci/hotplug/acpiphp.h > @@ -113,7 +113,7 @@ struct acpiphp_slot { > > u8 device; /* pci device# */ > > - u32 sun; /* ACPI _SUN (slot unique number) */ > + unsigned long long sun; /* ACPI _SUN (slot unique number) */ Why not make it u64 if that's what ACPI says it should be? -- Ville Syrj?l? syrjala@sci.fi http://www.sci.fi/~syrjala/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/