Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757637AbYLKU1u (ORCPT ); Thu, 11 Dec 2008 15:27:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756160AbYLKU1m (ORCPT ); Thu, 11 Dec 2008 15:27:42 -0500 Received: from ns2.suse.de ([195.135.220.15]:47599 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752309AbYLKU1l (ORCPT ); Thu, 11 Dec 2008 15:27:41 -0500 Date: Thu, 11 Dec 2008 21:27:36 +0100 Message-ID: From: Takashi Iwai To: "Rafael J. Wysocki" Cc: Jesse Barnes , Linus Torvalds , Greg KH , Ingo Molnar , Len Brown , LKML , Andrew Morton , pm list Subject: Re: [PATCH 3/3] Sound (HDA Intel): Restore PCI configuration space with interrupts off In-Reply-To: <200812112103.17018.rjw@sisk.pl> References: <200812020320.31876.rjw@sisk.pl> <200812112103.17018.rjw@sisk.pl> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.3 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1884 Lines: 50 At Thu, 11 Dec 2008 21:03:16 +0100, Rafael J. Wysocki wrote: > > On Thursday, 11 of December 2008, Takashi Iwai wrote: > > At Sun, 07 Dec 2008 10:47:56 +0100, > > I wrote: > > > > > > At Sat, 6 Dec 2008 20:45:35 -0800, > > > Jesse Barnes wrote: > > > > > > > > On Saturday, December 6, 2008 6:09 am Rafael J. Wysocki wrote: > > > > > From: Rafael J. Wysocki > > > > > Subject: Sound (HDA Intel): Restore PCI configuration space with interrupts > > > > > off > > > > > > > > > > Move the restoration of the standard PCI configuration registers > > > > > in the snd_hda_intel driver to a ->resume_early() callback executed > > > > > with interrupts disabled, since doing that with interrupts enabled > > > > > may lead to problems in some cases. > > > > > > > > > > This patch addresses the regression from 2.6.26 tracked as > > > > > http://bugzilla.kernel.org/show_bug.cgi?id=12121 . > > > > > > > > Since I only applied 1 and 2 you'll need to send this one through Takashi. > > > > > > OK, I merged it to for-next branch now. > > > It should appear in the linux-next tree of tomorrow. > > > > There is no build errors at least on linux-next, but I guess the > > testing about PM has been rarely done on linux-next kernel... > > > > BTW, Rafael, is this particular patch (against hda_intel.c) works in > > general or dependent on other two patches? > > It should be safe without the other patches too. OK, but this alone doesn't make much sense without others, right? I'm asking this because I'm not pretty sure how this should be handled. Certainly it must be in 2.6.29, but about for 2.6.28... thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/