Subject: USB interrupt handler routine
From: Keith Packard <keithp@keithp.com>
To: Greg Kroah-Hartman <greg@kroah.com>,
       linux-kernel <linux-kernel@vger.kernel.org>
Cc: keithp@keithp.com
Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-tntCDw6plXxT8aoIb0E8"
Date: Thu, 11 Dec 2008 20:35:37 -0800
Message-Id: <1229056537.4137.10.camel@aiko.keithp.com>
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1763
Lines: 49


--=-tntCDw6plXxT8aoIb0E8
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

We recently made a patch in the Intel DRM driver:

http://git.kernel.org/?p=3Dlinux/kernel/git/torvalds/linux-2.6.git;a=3Dcomm=
it;h=3Db60678a75d44fa9d5969f79781bd856ad5858609

This switches from non-MSI to MSI-mode.

It "should" have had no effect, but our concern is that what we're
really seeing is interrupt sharing troubles. We've had several people
say that they got an interrupt flood when plugging in a USB stick or
external disk. Switching the graphics driver to MSI mode "cures" the
bug, but that sure seems like a work-around rather than a bug fix to me.

When our driver is active, it can generate a lot of interrupts,
potentially thousands per second. Is it possible that the UHCI or EHCI
drivers could get confused if checking for interrupt status this often?

Eric noted that the USB driver appears to not check and ACK interrupt
status unconditionally, preferring to check the software state
beforehand. I'm wondering if this may open up a potential race between
hardware state change and ISR bit setting.
=09
--=20
keith.packard@intel.com

--=-tntCDw6plXxT8aoIb0E8
Content-Type: application/pgp-signature; name=signature.asc
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQBJQeoYQp8BWwlsTdMRAkmZAKDFResltOiuP55QiENdue1t2G3TbwCeLfzd
i0MfCCpArHgYDjx2xOstHjE=
=rcfN
-----END PGP SIGNATURE-----

--=-tntCDw6plXxT8aoIb0E8--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/