DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=jn1P28Dxaxqp+aTLrVRd0COm1A3nbusFghPSDpyFK5kRzsNi7rnH7VRy0/n88D6mAU
         C3dbkE4V0+hkzzJYYI7A4bY51srjc5DITilHCv18695m3zkLFVRyIh5Ft9UKKpFliG/R
         0nrz3H5RGITBi+c5Vu5NS+jZEC+5A+rEHiG5o=
Message-ID: <2aac3c260812120120i7e48f828s3817818a2c152a98@mail.gmail.com>
Date: Fri, 12 Dec 2008 10:20:44 +0100
From: "Giangiacomo Mariotti" <giangiacomo.mariotti@gmail.com>
To: "Francois Romieu" <romieu@fr.zoreil.com>
Subject: Re: weird realtek gigabit ethernet issue
Cc: "Shaya Potter" <spotter@yucs.org>, linux-kernel@vger.kernel.org
In-Reply-To: <20081211220028.GB25911@electric-eye.fr.zoreil.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <2aac3c260812072334v5d85ca2cke6cd33d7c912b8ea@mail.gmail.com>
	 <20081208224023.GA8492@electric-eye.fr.zoreil.com>
	 <2aac3c260812081519j4739af7cve93606a46c07b218@mail.gmail.com>
	 <20081208232425.GA8174@electric-eye.fr.zoreil.com>
	 <2aac3c260812091816n41afa4aex101569cdfab130ce@mail.gmail.com>
	 <20081210201818.GA30146@electric-eye.fr.zoreil.com>
	 <2aac3c260812102029p3da46d44h91eebcdbb4f1c5c0@mail.gmail.com>
	 <20081211082805.GA14963@electric-eye.fr.zoreil.com>
	 <2aac3c260812110128s10c71271nf497124bd3d05de0@mail.gmail.com>
	 <20081211220028.GB25911@electric-eye.fr.zoreil.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2812
Lines: 61

On Thu, Dec 11, 2008 at 11:00 PM, Francois Romieu <romieu@fr.zoreil.com> wrote:
> (Ccing l-k as it may be of wider interest)
>
> Giangiacomo Mariotti <giangiacomo.mariotti@gmail.com> :
>> 2008/12/11 Francois Romieu <romieu@fr.zoreil.com>:
>> > Giangiacomo Mariotti <giangiacomo.mariotti@gmail.com> :
>> > [...]
>> >> Dec  7 10:13:56 debian-hell kernel: [    4.064402] eth0: RTL8169 at
>> >> 0xffffc2000062a000, 00:1f:d0:ae:41:0e, XID 281000c0 IRQ 1270
>> >> Dec  7 10:13:56 debian-hell kernel: [    5.325793] eth1: RTL8169 at
>> >> 0xffffc20000630000, 00:1f:d0:ae:41:10, XID 281000c0 IRQ 1269
>> >> Dec  8 06:09:31 debian-hell kernel: [    6.253241] eth0:
>> >> RTL8168d/8111d at 0xffffc2000064e000, 00:1f:d0:ae:41:0e, XID 281000c0
>> >> IRQ 1270
>> >> Dec  8 06:09:31 debian-hell kernel: [    6.258123] eth1:
>> >> RTL8168d/8111d at 0xffffc20000652000, 00:1f:d0:ae:41:10, XID 281000c0
>> >> IRQ 1269
> [...]
>> On Dec 8, at 06, I booted 2.6.28-rc7, while on Dec 7, at 10, I booted
>> 2.6.26-1-amd64(debian, based on 2.6.26.8). I can't find any log for
>> 2.6.27.8.
>
> Ok. Looking at your logs and at the r8169.c code, here is the story.
>
> 1. On December 7, the r8169.c driver identifies your network card as an
>   (old) "RTL8169" i.e. RTL_GIGA_MAC_VER_01 in r8169.c. This is the default
>   choice when there is no specific match for the XID. You can check this
>   in r8169.c::rtl8169_get_mac_version. Below RTL_GIGA_MAC_VER_06, the
>   driver assumes that the device includes a "RxMissed" register (see
>   r8169.c::rtl8169_rx_missed). This assumption is false for your device
>   - as it is on nearly all new 816x flavors nowadays - and you will
>   experience a broken rx missed counter in ifconfig's output.
>
> 2. On December 8, the r8169 driver identifies your network card as a more
>   modern "RTL8168d/8111d" i.e. RTL_GIGA_MAC_VER_25. As far as I know, it
>   should be the adequate choice given the XID. r8169.c::rtl8169_rx_missed
>   will not try to access the non-existant RxMissed register and your
>   stats should be fine.
>
> While the fix for the RxMissed register access is in the stable branch,
> it is useless if the adapter is (mis-)detected as an old RTL8169.
>
> So, currently, your rx missed counters should be broken on anything
> older than 2.6.28-rc1. If they were vanilla kernel (I have not checked
> the content of Debian's kernel), Dec 7 should be broken and Dec 8 should
> be ok.
>
> Does the explanation above match your observations ?
>
Yes.

> Btw I should probably push new RTL_GIGA_MAC_VER_XX into -stable.
>
> --
> Ueimor
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/