Subject: Re: [RFC PATCH -v4 11/14] fsnotify: include pathnames with entries
 when possible
From: Eric Paris <eparis@redhat.com>
To: Evgeniy Polyakov <zbr@ioremap.net>
Cc: linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
       viro@ZenIV.linux.org.uk, hch@infradead.org, akpm@linux-foundation.org,
       alan@lxorguk.ukuu.org.uk
In-Reply-To: <20081213031920.GG807@ioremap.net>
References: <20081212213915.27112.57526.stgit@paris.rdu.redhat.com>
	 <20081212215212.27112.73418.stgit@paris.rdu.redhat.com>
	 <20081213031920.GG807@ioremap.net>
Content-Type: text/plain
Date: Sat, 13 Dec 2008 11:42:42 -0500
Message-Id: <1229186562.29167.108.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1308
Lines: 28

On Sat, 2008-12-13 at 06:19 +0300, Evgeniy Polyakov wrote:
> On Fri, Dec 12, 2008 at 04:52:12PM -0500, Eric Paris (eparis@redhat.com) wrote:
> > When inotify wants to send events to a directory about a child it includes
> > the name of the original file.  This patch collects that filename and makes
> > it available for notification.
> 
> What about extending fsnotify with attributes so that there would be no
> problems extending it with new events and data sent to userspace?

Since struct fsnotify_event is not exported to userspace information may
be collected in there at event creation time.  I actually have a number
of later patches that do this for information that I want to send for
fanotify.

Information can also be stored in the event->private area if only one
group really cares....   (kinda how I store wd for inotify)

Information which is useful to more than 1 group should be added to
struct fsnotify_event and its up to the individual listeners to export
that to userspace anyway they want to.

So absolutely this is completely extensible.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/