Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754516AbYLNJfW (ORCPT ); Sun, 14 Dec 2008 04:35:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752046AbYLNJfH (ORCPT ); Sun, 14 Dec 2008 04:35:07 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:36326 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751087AbYLNJfE (ORCPT ); Sun, 14 Dec 2008 04:35:04 -0500 Date: Sun, 14 Dec 2008 10:28:27 +0100 From: Pavel Machek To: Linus Torvalds Cc: "Rafael J. Wysocki" , Arjan van de Ven , Alan Stern , Takashi Iwai , Greg KH , LKML , Jesse Barnes , pm list , Ingo Molnar , Andrew Morton Subject: Re: [linux-pm] [PATCH 1/3] PCI: Rework default handling of suspend and resume Message-ID: <20081214092827.GA1445@ucw.cz> References: <200812071439.27712.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1061 Lines: 25 On Sun 2008-12-07 08:34:43, Linus Torvalds wrote: > On Sun, 7 Dec 2008, Rafael J. Wysocki wrote: > > > > So, can we just say that PCI drivers shouldn't free IRQs during suspend and > > request them during resume, and if there's any problem that leads to, then it > > should be solved differently? > > Well, there are reasons why _individual_ drivers might want to free and > re-request irq's during suspend, so I wouldn't say it's wrong either. Another (not too good) reason why you may want to unregister the interrupt is similarity between suspend and rmmod (and resume and insmod). In some cases you can get away with sharing code between those two paths... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/