Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753101AbYLOGUw (ORCPT ); Mon, 15 Dec 2008 01:20:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751237AbYLOGUn (ORCPT ); Mon, 15 Dec 2008 01:20:43 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:39437 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750904AbYLOGUm (ORCPT ); Mon, 15 Dec 2008 01:20:42 -0500 Date: Sun, 14 Dec 2008 22:20:43 -0800 (PST) Message-Id: <20081214.222043.249008274.davem@davemloft.net> To: paulus@samba.org Cc: matthew@wil.cx, kraxel@redhat.com, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v2] Add preadv and pwritev system calls. From: David Miller In-Reply-To: <18757.55706.609537.196994@drongo.ozlabs.ibm.com> References: <1229090440-32120-1-git-send-email-kraxel@redhat.com> <20081212152929.GM26095@parisc-linux.org> <18757.55706.609537.196994@drongo.ozlabs.ibm.com> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1309 Lines: 28 From: Paul Mackerras Date: Mon, 15 Dec 2008 15:14:18 +1100 > Matthew Wilcox writes: > > > On Fri, Dec 12, 2008 at 03:00:40PM +0100, Gerd Hoffmann wrote: > > > The patch sports the actual system call implementation and the windup in > > > the x86 system call tables. Other archs are TBD. > > > > > +asmlinkage ssize_t sys_preadv(unsigned long fd, const struct iovec __user *vec, > > > + unsigned long vlen, loff_t pos) > > > +asmlinkage ssize_t sys_pwritev(unsigned long fd, const struct iovec __user *vec, > > > + unsigned long vlen, loff_t pos) > > > > Are these prototypes required? MIPS and PARISC will need wrappers to > > fix them if they are. These two architectures have an ABI which > > requires 64-bit arguments to be passed in aligned pairs of registers, > > As does 32-bit PowerPC, so I also would prefer the alternate argument > order for the syscall (pos as the 3rd argument). FWIW 32-bit sparc does not have the aligned register requirement for 64-bit arguments. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/