Message-ID: <49464922.1070404@cam.ac.uk>
Date: Mon, 15 Dec 2008 12:10:10 +0000
From: Jonathan Cameron <jic23@cam.ac.uk>
User-Agent: Thunderbird 2.0.0.16 (X11/20080801)
MIME-Version: 1.0
To: Mark Brown <broonie@sirena.org.uk>
CC: Mike Rapoport <mike@compulab.co.il>, LKML <linux-kernel@vger.kernel.org>,
       felipe.balbi@nokia.com, Liam Girdwood <lrg@kernel.org>
Subject: Re: [PATCH] mfd: DA9030 USB charge pump mode selection support
References: <4943FA3E.9090507@cam.ac.uk> <49461CFB.9080108@compulab.co.il> <20081215104730.GA31145@sirena.org.uk>
In-Reply-To: <20081215104730.GA31145@sirena.org.uk>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1210
Lines: 29

Mark Brown wrote:
> On Mon, Dec 15, 2008 at 11:01:47AM +0200, Mike Rapoport wrote:
>> Jonathan Cameron wrote:
> 
>>> The main question on this is whether it should just be rolled into
>>> the core mfd driver.  I'm inclined to keep it separate and decidedly
>>> optional as the fact it isn't already in the driver implies that
>>> it may not be commonly used. (Intel Stargate 2 does need this
>>> functionality though, hence the submission as I'm hoping to get
>>> the relevant board code in soonish.)
> 
>> I'm for adding "da9030_set_usb_charge_pump_mode" to the core mfd driver.
> 
> Me too - if there are concerns about kernel size a config option could
> be added to allow users to select it.  Unless we get an abstraction for
> these USB power sources (which might be useful) a separate driver
> doesn't seem to buy much.
> 
Fair enough, I'll admit I thought there would be rather more to it when I
started writing that!

New patch to follow shortly.

Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/