Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751836AbYLOMiY (ORCPT ); Mon, 15 Dec 2008 07:38:24 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750902AbYLOMiQ (ORCPT ); Mon, 15 Dec 2008 07:38:16 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:33172 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750805AbYLOMiP (ORCPT ); Mon, 15 Dec 2008 07:38:15 -0500 Date: Mon, 15 Dec 2008 23:38:01 +1100 From: Herbert Xu To: Huang Ying Cc: "Siddha, Suresh B" , Sebastian Andrzej Siewior , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "mingo@elte.hu" , "tglx@linutronix.de" Subject: Re: [RFC PATCH crypto] AES: Add support to Intel AES-NI instructions Message-ID: <20081215123801.GA32485@gondor.apana.org.au> References: <1229054926.5936.160.camel@yhuang-dev.sh.intel.com> <20081212195722.GA24489@Chamillionaire.breakpoint.cc> <1229307542.5936.204.camel@yhuang-dev.sh.intel.com> <20081215033842.GA28499@gondor.apana.org.au> <1229318099.5936.224.camel@yhuang-dev.sh.intel.com> <20081215052106.GA29324@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081215052106.GA29324@gondor.apana.org.au> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1064 Lines: 29 On Mon, Dec 15, 2008 at 04:21:06PM +1100, Herbert Xu wrote: > > > a. Do not touch SSE state in soft_irq > > b. Disable/restore soft_irq in kernel_fpu_begin/kernel_fpu_end > > c. Use a per-CPU data structure to save kernel FPU state during > > soft_irq. > > > > The mothod a is used in patch. > > Could you run the tcrypt speed test on this and measure the > difference between the native AES vs. the fallback? Depending > on the difference I think we'd want to consider b) or c). Here's another option d. When we're in interrupt context, schedule a task to perform the encryption asynchronously. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/