Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756458AbYLOUTS (ORCPT ); Mon, 15 Dec 2008 15:19:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753241AbYLOUTE (ORCPT ); Mon, 15 Dec 2008 15:19:04 -0500 Received: from brick.kernel.dk ([93.163.65.50]:15931 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752312AbYLOUTC (ORCPT ); Mon, 15 Dec 2008 15:19:02 -0500 Date: Mon, 15 Dec 2008 21:18:36 +0100 From: Jens Axboe To: Alexander Beregalov Cc: "linux-next@vger.kernel.org" , LKML Subject: Re: next-20081215: kernel BUG at block/cfq-iosched.c:1243 Message-ID: <20081215201836.GM32491@kernel.dk> References: <20081215183235.GG32491@kernel.dk> <20081215184440.GI32491@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1360 Lines: 39 On Mon, Dec 15 2008, Alexander Beregalov wrote: > 2008/12/15 Jens Axboe : > > On Mon, Dec 15 2008, Alexander Beregalov wrote: > >> 2008/12/15 Jens Axboe : > >> >> [ 23.080733] kernel BUG at block/cfq-iosched.c:1243! > >> >> [ 23.080733] invalid opcode: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC > >> > >> > Odd, is it reproducible? What is your .config? > >> Yes, it is > >> > >> Config is in attach > > > > It's weird, because the only change for CFQ in that area is the one > > below. Does the oops go away if you back this out? > Yes, it can boot without the patch, no oops. OK, dumb error. Please try this instead, on top of -next: diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c index 8a2485d..e8525fa 100644 --- a/block/cfq-iosched.c +++ b/block/cfq-iosched.c @@ -1322,7 +1322,6 @@ static void cfq_exit_single_io_context(struct io_context *ioc, smp_read_barrier_depends(); if (cic->key) __cfq_exit_single_io_context(cfqd, cic); - __cfq_exit_single_io_context(cfqd, cic); spin_unlock_irqrestore(q->queue_lock, flags); } -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/