Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754874AbYLOW17 (ORCPT ); Mon, 15 Dec 2008 17:27:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751844AbYLOW1v (ORCPT ); Mon, 15 Dec 2008 17:27:51 -0500 Received: from ozlabs.org ([203.10.76.45]:37246 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbYLOW1u (ORCPT ); Mon, 15 Dec 2008 17:27:50 -0500 From: Rusty Russell To: Mark McLoughlin Subject: Re: [PATCH 2/4] virtio: do not statically allocate root device Date: Tue, 16 Dec 2008 08:57:47 +1030 User-Agent: KMail/1.10.3 (Linux/2.6.27-9-generic; KDE/4.1.3; i686; ; ) Cc: Greg KH , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Anthony Liguori , Kay Sievers , Cornelia Huck References: <20081212190730.GB2950@kroah.com> <1229345909-27229-1-git-send-email-markmc@redhat.com> <1229345909-27229-2-git-send-email-markmc@redhat.com> In-Reply-To: <1229345909-27229-2-git-send-email-markmc@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200812160857.48321.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 557 Lines: 16 On Monday 15 December 2008 23:28:27 Mark McLoughlin wrote: > We shouldn't be statically allocating the root device object, > so dynamically allocate it using root_device_register() > instead. This and 3/4 which would normally go through me: Acked-by: Rusty Russell Thanks Greg, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/