Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758559AbYLPP6u (ORCPT ); Tue, 16 Dec 2008 10:58:50 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757055AbYLPP6i (ORCPT ); Tue, 16 Dec 2008 10:58:38 -0500 Received: from aeryn.fluff.org.uk ([87.194.8.8]:57932 "EHLO kira.home.fluff.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756770AbYLPP6h (ORCPT ); Tue, 16 Dec 2008 10:58:37 -0500 Date: Tue, 16 Dec 2008 15:58:22 +0000 From: Ben Dooks To: Hannes Eder Cc: Jiri Kosina , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] HID: avoid sparse warning in HID_COMPAT_LOAD_DRIVER Message-ID: <20081216155822.GD12431@fluff.org.uk> References: <4947a48f.08b6660a.34ca.ffffa1e8@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4947a48f.08b6660a.34ca.ffffa1e8@mx.google.com> X-Disclaimer: These are my own opinions, so there! User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1603 Lines: 47 On Tue, Dec 16, 2008 at 01:31:31PM +0100, Hannes Eder wrote: > Impact: include a prototype for the exported function in the macro > > Fix about 20 of this warnings: > > drivers/hid/hid-a4tech.c:162:1: warning: symbol 'hid_compat_a4tech' was not declared. Should it be static? > > Signed-off-by: Hannes Eder > --- > include/linux/hid.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/linux/hid.h b/include/linux/hid.h > index 215035b..81aa84d 100644 > --- a/include/linux/hid.h > +++ b/include/linux/hid.h > @@ -793,6 +793,8 @@ dbg_hid(const char *fmt, ...) > > #ifdef CONFIG_HID_COMPAT > #define HID_COMPAT_LOAD_DRIVER(name) \ > +/* prototype to avoid sparse warning */ \ > +extern void hid_compat_##name(void); \ > void hid_compat_##name(void) { } \ surely this could simply be changed to 'static void hid_compat_##name(void)' if it is only being defined to be an empty function? > EXPORT_SYMBOL(hid_compat_##name) > #else > -- > 1.5.6.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Ben (ben@fluff.org, http://www.fluff.org/) 'a smiley only costs 4 bytes' -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/