Date: Thu, 18 Dec 2008 23:14:07 +0000
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Matt Mackall <mpm@selenic.com>, davem@davemloft.net,
       linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Stop scaring users with "treason uncloaked!"
Message-ID: <20081218231407.4096a64e@lxorguk.ukuu.org.uk>
In-Reply-To: <20081218230253.GA1855@gondor.apana.org.au>
References: <1229638581.3726.546.camel@calx>
	<E1LDRbc-0000Ro-1j@gondolin.me.apana.org.au>
	<20081218224905.2bc81664@lxorguk.ukuu.org.uk>
	<20081218230253.GA1855@gondor.apana.org.au>
Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street,
 Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a
 Lloegr o'r rhif cofrestru 3798903
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 861
Lines: 24

On Fri, 19 Dec 2008 10:02:53 +1100
Herbert Xu <herbert@gondor.apana.org.au> wrote:

> On Thu, Dec 18, 2008 at 10:49:05PM +0000, Alan Cox wrote:
> >
> > It was changed. The printer on fire ? bit was adjusted to make it clear
> > because the original message *did* confuse and worry a few people.
> 
> Well
> 
> $ grep fire drivers/char/lp.c
>                         printk(KERN_INFO "lp%d on fire\n", minor);

Interesting. It got changed and then the change got lost between 2.2 and
2.4 somewhere. It was changed to report

"lp0 reported invalid error status (on fire, eh?)"

and it looks like that needs re-fixing.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/