Date: Thu, 18 Dec 2008 16:08:15 -0800 (PST)
Message-Id: <20081218.160815.106790562.davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: mpm@selenic.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] Stop scaring users with "treason uncloaked!"
From: David Miller <davem@davemloft.net>
In-Reply-To: <Pine.LNX.4.64.0812190028560.12061@wrl-59.cs.helsinki.fi>
References: <1229638581.3726.546.camel@calx>
	<Pine.LNX.4.64.0812190028560.12061@wrl-59.cs.helsinki.fi>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 982
Lines: 24

From: "Ilpo J?rvinen" <ilpo.jarvinen@helsinki.fi>
Date: Fri, 19 Dec 2008 00:33:46 +0200 (EET)

> On Thu, 18 Dec 2008, Matt Mackall wrote:
> 
> > These debug messages are uninformative and extremely alarming. Rather
> > than reporting a peer as a treacherous attacker, report it more
> > correctly as simply broken. 
> 
> Last time (well, ignoring some report on ancient vendor kernel) I've seen 
> this to trigger it wasn't the fault of the peer but ours (we sent past the 
> advertized window and window ended up being shrunk to zero). I agree that 
> the message as-is is not very good but your change is not very good 
> either.
 ...
> This won't apply to net-next on which you should base anything new (and 
> net related).

Agreed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/