Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753004AbYLSBWV (ORCPT ); Thu, 18 Dec 2008 20:22:21 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752126AbYLSBWD (ORCPT ); Thu, 18 Dec 2008 20:22:03 -0500 Received: from ozlabs.org ([203.10.76.45]:57032 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751588AbYLSBWB (ORCPT ); Thu, 18 Dec 2008 20:22:01 -0500 From: Rusty Russell To: Dave Jones Subject: Re: [PATCH] net: Remove a noisy printk Date: Fri, 19 Dec 2008 11:51:54 +1030 User-Agent: KMail/1.10.3 (Linux/2.6.27-9-generic; KDE/4.1.3; i686; ; ) Cc: Jozsef Kadlecsik , Jan Engelhardt , David Miller , ajax@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, Patrick McHardy References: <1229033625-30825-1-git-send-email-ajax@redhat.com> <20081214200353.GA2994@redhat.com> In-Reply-To: <20081214200353.GA2994@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200812191151.55607.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1086 Lines: 23 On Monday 15 December 2008 06:33:53 Dave Jones wrote: > On Sun, Dec 14, 2008 at 06:09:17PM +0100, Jozsef Kadlecsik wrote: > > In a >normal< system one usually does not use raw sockets. So if a root > > process do use raw socket, at least netfilter sends a notification and > > there's a chance that someone take notice it by checking the kernel logs. > > 'normal' systems are irrelevant here. This message is triggerable remotely. I don't think it can be. This is for truncated locally-generated outgoing packets, which can only happen when root is playing with raw sockets. As you can probably tell, I was the one who wrote this printk :) IMHO, one reasonable complaint is sufficient to have it removed, so just remove it. If anyone thinks it's valuable, put a static counter < 5 around it and add pid/comm info. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/