Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753869AbYLSKua (ORCPT ); Fri, 19 Dec 2008 05:50:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752440AbYLSKuW (ORCPT ); Fri, 19 Dec 2008 05:50:22 -0500 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:51507 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751655AbYLSKuV (ORCPT ); Fri, 19 Dec 2008 05:50:21 -0500 Date: Fri, 19 Dec 2008 10:50:13 +0000 From: Alan Cox To: Bartlomiej Zolnierkiewicz Cc: Sergei Shtylyov , Jeff Garzik , Mario Schwalbe , linux-kernel@vger.kernel.org, Linux IDE mailing list Subject: Re: [PATCH] ide: Fix ata_id_has_dword_io to return DWORD I/O support properly Message-ID: <20081219105013.0e43c364@lxorguk.ukuu.org.uk> In-Reply-To: <200812190013.10156.bzolnier@gmail.com> References: <494A5BBF.8000807@inf.tu-dresden.de> <200812182142.16533.bzolnier@gmail.com> <20081218224010.45e3ce55@lxorguk.ukuu.org.uk> <200812190013.10156.bzolnier@gmail.com> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.12; x86_64-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 722 Lines: 15 > Sure, we can always improve things further later. However Mario's patch > is _definitely_ an improvement over the _current_ code. Don't you agree? No actually I don't. The current head dev code checks ATA > 7 as the indicator that this bit is used for treacherous computing. That means the behaviour for all the older drives is clearly back compatible with old Linux behaviour. Doing it that way around means we don't have any worries about changing existing behaviours. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/