Message-ID: <494C1D20.9000008@ct.jp.nec.com>
Date: Fri, 19 Dec 2008 14:16:00 -0800
From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
User-Agent: Thunderbird 2.0.0.18 (Windows/20081105)
MIME-Version: 1.0
To: Ingo Molnar <mingo@elte.hu>
Cc: Toshikazu Nakayama <nakayama.ts@ncos.nec.co.jp>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: fix discarding message when recursion_bug
References: <494BE687.2040700@ct.jp.nec.com> <20081219215347.GG2351@elte.hu>
In-Reply-To: <20081219215347.GG2351@elte.hu>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1249
Lines: 33

Ingo Molnar wrote:
> * Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> wrote:
> 
>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>>
>> Impact: fix
>>
>> When recursion_bug is true, kernel discards original message because printk_buf
>> contains recursion_bug_msg with NULL terminator. The sizeof(recursion_bug_msg)
>> makes this, use strlen() to get correct length without NULL terminator.
>>
>> Reported-by: Toshikazu Nakayama <nakayama.ts@ncos.nec.co.jp>
>> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>> ---
>>  kernel/printk.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Good one - applied to tip/core/printk, thanks!
> 
> Btw., i'm curious: in what situation was such recursion observed, and how 
> did the kernel behave? You saw a truncated recursion message in dmesg - or 
> was it worse?

I'm not sure about the real situation. I've heard this issue was found in
printing messages in NMI handler, maybe with artificial kernel stuck.

Thanks,
Hiroshi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/