Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752486AbYLUVse (ORCPT ); Sun, 21 Dec 2008 16:48:34 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751279AbYLUVsY (ORCPT ); Sun, 21 Dec 2008 16:48:24 -0500 Received: from styx.suse.cz ([82.119.242.94]:36903 "EHLO mail.suse.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751256AbYLUVsX (ORCPT ); Sun, 21 Dec 2008 16:48:23 -0500 Date: Sun, 21 Dec 2008 22:48:21 +0100 (CET) From: Jiri Kosina To: Parag Warudkar cc: Anssi Hannula , Andrew Morton , LKML , linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] USBHID: Make Boot Protocol drivers depend on EMBEDDED In-Reply-To: Message-ID: References: <20081220221253.e09b1b1f.akpm@linux-foundation.org> <494E20F7.7050106@gmail.com> User-Agent: Alpine 1.10 (LNX 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 37 On Sun, 21 Dec 2008, Parag Warudkar wrote: > The usbmouse and usbkbd modules are not supposed to be used with regular > USB mice and keyboards. Make them depend on EMBEDDED to prevent them from > being built and loaded on non-EMBEDDED configs. > > Signed-off-by: Parag Warudkar > > diff --git a/drivers/hid/usbhid/Kconfig b/drivers/hid/usbhid/Kconfig > index 5d9aa95..4edb3be 100644 > --- a/drivers/hid/usbhid/Kconfig > +++ b/drivers/hid/usbhid/Kconfig > @@ -45,7 +45,7 @@ config USB_HIDDEV > If unsure, say Y. > > menu "USB HID Boot Protocol drivers" > - depends on USB!=n && USB_HID!=y > + depends on USB!=n && USB_HID!=y && EMBEDDED > > config USB_KBD > tristate "USB HIDBP Keyboard (simple Boot) support" So do I get it right that the only reason of the problem you were seeing was that in the 2.6.27 kernel you have compiled usbhid module, which was then used for driving your mouse,but in 2.6.28-rcX you compiled and used 'usbmouse' instead, and therefore this is not a regression? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/