Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754957AbYLVQid (ORCPT ); Mon, 22 Dec 2008 11:38:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751483AbYLVQiX (ORCPT ); Mon, 22 Dec 2008 11:38:23 -0500 Received: from caramon.arm.linux.org.uk ([78.32.30.218]:36075 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751126AbYLVQiX (ORCPT ); Mon, 22 Dec 2008 11:38:23 -0500 Date: Mon, 22 Dec 2008 16:33:09 +0000 From: Russell King - ARM Linux To: Julia Lawall Cc: kernel@pengutronix.de, linux-arm-kernel@lists.arm.linux.org.uk, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/2] arch/arm/plat-mxc: Add local_irq_restore in error handling code Message-ID: <20081222163309.GA16392@n2100.arm.linux.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 633 Lines: 12 On Sun, Dec 21, 2008 at 09:54:23PM +0100, Julia Lawall wrote: > There is a call to local_irq_restore in the normal exit case, so it would > seem that there should be one on an error return as well. Please check what's queued up for the next merge; a similar change is already merged as part of a larger patch. (which is more correct since it calls local_irq_restore before the printk.) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/