Message-ID: <49506BBC.8040600@kernel.org>
Date: Tue, 23 Dec 2008 13:40:28 +0900
From: Tejun Heo <tj@kernel.org>
User-Agent: Thunderbird 2.0.0.18 (X11/20081112)
MIME-Version: 1.0
To: Robert Hancock <hancockr@shaw.ca>
CC: ide <linux-ide@vger.kernel.org>,
       linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sata_sil: add Large Block Transfer support
References: <4945BDED.7050205@shaw.ca> <494F69C4.2060708@kernel.org> <49506AAF.3040400@shaw.ca>
In-Reply-To: <49506AAF.3040400@shaw.ca>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1163
Lines: 34

Hello, Robert.

Robert Hancock wrote:
> Tejun Heo wrote:
>>
>> ioread/iowrite?
> 
> We know the register's always MMIO on this controller, so it's slightly
> more optimal to avoid the conditional in there.

Yeah, by a small margin but I think the consensus was to use
ioread/write no matter what if it's mapped using iomap.  I don't think
we guarantee iomapped address == mmio address after all.

>> I know it's not specific to this change but does mb() really make
>> sense here?  I don't think we need any barrier here.
> 
> Not sure. Documentation/memory-barriers.txt seems rather unfortunately
> vague on whether MMIO writes are strongly ordered with respect to memory
> writes. I seem to recall some debate on this a while ago, did it ever
> get resolved?

I remember that thread too but don't really any definite conclusion.
Eh... I hate barriers lying around without exact explanation.  :-(

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/