From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Thomas Gleixner <tglx@linutronix.de>
Subject: Re: TSC not updating after resume: Bug or Feature?
Date: Tue, 23 Dec 2008 15:15:14 +0100
User-Agent: KMail/1.9.9
Cc: Ingo Molnar <mingo@elte.hu>, Peter Zijlstra <peterz@infradead.org>,
       Steven Rostedt <srostedt@redhat.com>, dsaxena@plexity.net,
       linux-kernel@vger.kernel.org, Dave Kleikamp <shaggy@linux.vnet.ibm.com>
References: <20081217172758.GA6010@trantor.hsd1.or.comcast.net> <200812230147.32340.rjw@sisk.pl> <alpine.LFD.2.00.0812230801440.3723@localhost.localdomain>
In-Reply-To: <alpine.LFD.2.00.0812230801440.3723@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Content-Disposition: inline
Message-Id: <200812231515.14979.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1321
Lines: 33

On Tuesday, 23 of December 2008, Thomas Gleixner wrote:
> On Tue, 23 Dec 2008, Rafael J. Wysocki wrote:
> > > Care to explain ?
> > 
> > Well, the fact that in the resume code path the clocksource is only updated as
> > a result of executing pci_set_power_state() is worrisome.  I would be more
> > reliable to update it directly at one point.
> 
> Hmm. We reactivate the clock sources from timekeeping resume():
> 
>      clocksource_resume();
> 
> How is this related to pci_set_power_state() ?

>From the original report:

"I am using ftrace to get a detailed timing analysis of the resume process 
on the OLPC XO laptop and am seeing that when we start running again, the
system timestamep is not being updated for several (hundreds of) thousands 
of cycles (~2000 ftrace entries). From following the ftrace, what is 
happening is that the clocksource is not updated until we run the cpu_idle() 
thread due to an explicit scheduling operation in the resume path that occurs 
via call to msleep from pci_set_power_state()."

That's what I was referring to.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/