Date: Tue, 23 Dec 2008 15:32:23 -0500
From: Chuck Ebbert <cebbert@redhat.com>
To: "H. Peter Anvin" <hpa@kernel.org>
Cc: Jaswinder Singh <jaswinder@infradead.org>, Ingo Molnar <mingo@elte.hu>,
       Andi Kleen <andi@firstfloor.org>, x86 maintainers <x86@kernel.org>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: traps.c replace #if CONFIG_X86_32 with #ifdef
 CONFIG_X86_32
Message-ID: <20081223153223.2802314f@dhcp-100-2-144.bos.redhat.com>
In-Reply-To: <49512BF5.2010705@kernel.org>
References: <1230049211.14358.2.camel@jaswinder.satnam>
	<49512BF5.2010705@kernel.org>
Organization: Red Hat, Inc.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 956
Lines: 30

On Tue, 23 Dec 2008 10:20:37 -0800
"H. Peter Anvin" <hpa@kernel.org> wrote:

> > --- a/arch/x86/kernel/traps.c
> > +++ b/arch/x86/kernel/traps.c
> > @@ -692,7 +692,7 @@ void math_error(void __user *ip)
> >  
> >  	err = swd & ~cwd & 0x3f;
> >  
> > -#if CONFIG_X86_32
> > +#ifdef CONFIG_X86_32
> >  	if (!err)
> >  		return;
> >  #endif
> 
> Applied to tip:x86/fpu, thanks.
> 
> Andi: you might have a perspective on this: in math_error() we bail out
> if there is no error on i386, but not on x86-64.  I am rather assuming
> that is because it simply can't happen on x86-64 (no IRQ 13 bullshit) so
> it wasn't necessary?
> 

Some 32-bit x86 clones generate math error interrupts when there is no
actual error.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/