DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:cc:in-reply-to:mime-version
         :content-type:content-transfer-encoding:content-disposition
         :references;
        b=fOke2v78RvqEl4P66CPyqP1j48k9u5BsBARuyFc7gJn67JHC7DyumtX/HXMd4H1o33
         nzumWVyBgHILT3rtgS09O0x4QAcD8/Cmqii/3+vuoAXIpASJh6tKaClebBB4T9lGzPex
         BE0KrgDhpdk91KNnqVr0VAidBIaacFD9lpGgs=
Message-ID: <961aa3350812231437x4debaf9byf230a63582561010@mail.gmail.com>
Date: Wed, 24 Dec 2008 07:37:48 +0900
From: "Akinobu Mita" <akinobu.mita@gmail.com>
To: "Josef Bacik" <jbacik@redhat.com>
Subject: Re: [PATCH] ext4: annotate unhandled kmem_cache_alloc() error
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
       "Theodore Tso" <tytso@mit.edu>, adilger@sun.com,
       linux-ext4@vger.kernel.org
In-Reply-To: <20081223142915.GA23303@unused.rdu.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20081223104016.GC7217@localhost.localdomain>
	 <20081223142915.GA23303@unused.rdu.redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 757
Lines: 20

> BUG_ON is good for devel things, but for stable stuff it's better to let
> somebody know an error occured rather than panic'ing the box.  The proper
> solution would be to do
>
> if (!new_entry)
>        return -ENOMEM;
>
> or if there is some out: label set ret to -ENOMEM and goto out, whatever is
> appropriate in the context.  Thanks,

I don't understand the code around here well.
But I think it is not that simple.

The "new_entry" is needed to free blocks. If it just returns error,
it leaks something.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/