Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753150AbYLXCpa (ORCPT ); Tue, 23 Dec 2008 21:45:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751915AbYLXCpM (ORCPT ); Tue, 23 Dec 2008 21:45:12 -0500 Received: from netrider.rowland.org ([192.131.102.5]:3607 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751753AbYLXCpL (ORCPT ); Tue, 23 Dec 2008 21:45:11 -0500 Date: Tue, 23 Dec 2008 21:45:09 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Anton Vorontsov cc: Andrew Morton , Greg Kroah-Hartman , David Brownell , Timur Tabi , Li Yang , , , Subject: Re: [PATCH] USB: Driver for Freescale QUICC Engine USB Host Controller In-Reply-To: <20081223210322.GA2802@oksana.dev.rtsoft.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 950 Lines: 25 On Wed, 24 Dec 2008, Anton Vorontsov wrote: > This patch adds support for the FHCI USB controller, as found > in the Freescale MPC836x and MPC832x processors. It can support > Full or Low speed modes. > > Quite a lot the hardware is doing by itself (SOF generation, CRC > generation and checking), though scheduling and retransmission is on > software's shoulders. > > This controller does not integrate the root hub, so this driver also > fakes one-port hub. External hub is required to support more than > one device. It looks like the kernel this was written for is several versions out of date. The driver is missing some critical calls to functions like usb_hcd_link_urb_to_ep(). Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/