Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752272AbYLXMa3 (ORCPT ); Wed, 24 Dec 2008 07:30:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751652AbYLXMaV (ORCPT ); Wed, 24 Dec 2008 07:30:21 -0500 Received: from smtprelay04.ispgateway.de ([80.67.18.16]:40292 "EHLO smtprelay04.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751621AbYLXMaU (ORCPT ); Wed, 24 Dec 2008 07:30:20 -0500 From: Ingo Oeser To: Rusty Russell Subject: Re: linux-next: parsing mem=700M broken Date: Wed, 24 Dec 2008 13:30:27 +0100 User-Agent: KMail/1.10.3 (Linux/2.6.27-9-generic; KDE/4.1.3; x86_64; ; ) Cc: Ingo Molnar , Yinghai Lu , Hugh Dickins , Stephen Rothwell , Andrew Morton , linux-kernel@vger.kernel.org References: <20081223143327.GF29151@elte.hu> <200812241808.16195.rusty@rustcorp.com.au> In-Reply-To: <200812241808.16195.rusty@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200812241330.29784.ioe-lkml@rameria.de> X-Df-Sender: 849595 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1141 Lines: 48 Hello Rusty, On Wednesday 24 December 2008, Rusty Russell wrote: > void __init finish_e820_parsing(void) > { > + bool userdef; maybe init with userdef = false; > + int i; > + > + if (memlimit) { > + e820_remove_range(memlimit, ULLONG_MAX - memlimit, E820_RAM, 1); > + userdef = true; > + } > + > + if (exactmap) { > +#ifdef CONFIG_CRASH_DUMP > + /* > + * If we are doing a crash dump, we still need to know > + * the real mem size before original memory map is > + * reset. > + */ > + saved_max_pfn = e820_end_of_ram_pfn(); > +#endif > + e820.nr_map = 0; > + userdef = true; > + } > + > + for (i = 0; i < user_e820.nr_map; i++) { > + e820_add_region(user_e820.map[i].addr, user_e820.map[i].size, > + user_e820.map[i].type); > + userdef = true; > + } > + > if (userdef) { > int nr = e820.nr_map; Because here it might be used uninitialized. Best Regards Ingo Oeser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/