Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752390AbYLXQOv (ORCPT ); Wed, 24 Dec 2008 11:14:51 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751412AbYLXQOl (ORCPT ); Wed, 24 Dec 2008 11:14:41 -0500 Received: from smtp.gentoo.org ([140.211.166.183]:45524 "EHLO smtp.gentoo.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267AbYLXQOk (ORCPT ); Wed, 24 Dec 2008 11:14:40 -0500 From: Mike Frysinger Organization: wh0rd.org To: Adrian McMenamin Subject: Re: [PATCH] sh: maple: Robust checking for errors on maple keyboard initialisation Date: Wed, 24 Dec 2008 11:59:13 -0500 User-Agent: KMail/1.10.3 (Linux/2.6.27.8; KDE/4.1.3; x86_64; ; ) Cc: lkmL , "linux-input" , "linux-sh" , Paul Mundt , Matt Fleming , Andrew Morton References: <1229797527.6502.18.camel@localhost.localdomain> In-Reply-To: <1229797527.6502.18.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7432194.PGOv0Vk5Ih"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <200812241159.15332.vapier@gentoo.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1715 Lines: 45 --nextPart7432194.PGOv0Vk5Ih Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Saturday 20 December 2008 13:25:27 Adrian McMenamin wrote: > - maple_set_drvdata(mdev, NULL); > - return error; > +fail: > + return -error; same comment as for the joystick driver ... it's weird and i'm pretty sure= =20 incorrect due to other functions setting error as well as this driver. =2Dmike --nextPart7432194.PGOv0Vk5Ih Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iQIcBAABAgAGBQJJUmpjAAoJEEFjO5/oN/WB8vUP+gLiz49YUsqfbp1pfCo5dkSY bKtdS2kYmdoMnSACebWJKvBjawN8w5XU+is5F4DPbxZzqFlP5uuKBa1RWGUXIGTG FOU1sKbI9Om3/4rh/9OMjJaytSkSALLPHaIXYwO3ivI1OlTfx2g+yz8e3vyIKFw6 V5PTRUMJan/RvFnPM50JtkKAxU7h7+hHbjkcxd9koD0dVgSmum77Wbt12bpaKVWi X+Nkx1twxwhuvPBu/+/aTQfIdmNUJ1eE5Agk7UpwT1WlN2+l5wQrSy8d+qee0Ygd M+EjNK/wStVG96Ho+k4vQuajUWWwaILFaBmvySHI5jld0Mx6h3zPJr7RA6qBw9MN UaR89M8uUuCvISfApRdLuHtUSdyh/I1CbVLxra4NZcyPUEN452/La3qphJ8Wqwg4 wSSrHY7UcPH+ww+0W11w/2h9cyPZ0n7X4inHnlfiDA5DfehPG8RTXe9vlIQUmtHx FhMU/f+F6EuGet6l3Xk+U3CUE2ElZprl7RacdfF26iS2ppTHi++VcE34Z4JHI1Vm cqxuaCnFL+/N03ZwztgAWfEOewZVZc0a4xWFU1M92qttA4rj9E4BWP82uejHxJch nrghA03elQ3dSOIE/YwPHe3m+fH5qzUwo2ZI4z9cQm83GJioKM29RCB/hOnom54Y RGQ4PwZrGav4yQS5Io3U =EysH -----END PGP SIGNATURE----- --nextPart7432194.PGOv0Vk5Ih-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/