Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751814AbYLXWyc (ORCPT ); Wed, 24 Dec 2008 17:54:32 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751289AbYLXWyX (ORCPT ); Wed, 24 Dec 2008 17:54:23 -0500 Received: from netrider.rowland.org ([192.131.102.5]:3985 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751272AbYLXWyW (ORCPT ); Wed, 24 Dec 2008 17:54:22 -0500 Date: Wed, 24 Dec 2008 17:54:21 -0500 (EST) From: Alan Stern X-X-Sender: stern@netrider.rowland.org To: Anton Vorontsov cc: Andrew Morton , Greg Kroah-Hartman , David Brownell , Timur Tabi , Li Yang , , , Subject: Re: [PATCH -mm 1/3] USB: FHCI: Driver should be responsible for managing endpoint queues In-Reply-To: <20081224191303.GA21815@oksana.dev.rtsoft.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1055 Lines: 35 On Wed, 24 Dec 2008, Anton Vorontsov wrote: > Follow these changes for the FHCI driver: > > commit e9df41c5c5899259541dc928872cad4d07b82076 > Author: Alan Stern > Date: Wed Aug 8 11:48:02 2007 -0400 > > USB: make HCDs responsible for managing endpoint queues On the whole this looks good. > --- a/drivers/usb/host/fhci-q.c > +++ b/drivers/usb/host/fhci-q.c > @@ -200,6 +200,9 @@ void urb_complete_free(struct fhci_hcd *fhci, struct urb *urb) > else > urb->status = 0; > } > + > + usb_hcd_unlink_urb_from_ep(fhci_to_hcd(fhci), urb); > + > spin_unlock(&fhci->lock); > > usb_hcd_giveback_urb(fhci_to_hcd(fhci), urb, urb->status); For the future you might think about not using urb->status at all. The intention is eventually to remove that field. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/