Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752082AbYLYBRT (ORCPT ); Wed, 24 Dec 2008 20:17:19 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751488AbYLYBRJ (ORCPT ); Wed, 24 Dec 2008 20:17:09 -0500 Received: from tundra.namei.org ([65.99.196.166]:2390 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751481AbYLYBRG (ORCPT ); Wed, 24 Dec 2008 20:17:06 -0500 Date: Thu, 25 Dec 2008 12:17:01 +1100 (EST) From: James Morris To: Casey Schaufler cc: Sergio Luis , "Ahmed S. Darwish" , LSM , LKLM Subject: Re: [PATCH] smackfs: check for allocation failures in smk_set_access() In-Reply-To: <49507107.4010809@schaufler-ca.com> Message-ID: References: <494F148F.8070101@larces.uece.br> <49507107.4010809@schaufler-ca.com> User-Agent: Alpine 1.10 (LRH 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1287 Lines: 38 On Mon, 22 Dec 2008, Casey Schaufler wrote: > Sergio Luis wrote: > > smackfs: check for allocation failures in smk_set_access() > > While adding a new subject/object pair to smack_list, smk_set_access() > > didn't check the return of kzalloc(). > > This patch changes smk_set_access() to return 0 or -ENOMEM, based on > > kzalloc()'s return. It also updates its caller, smk_write_load(), to > > check for smk_set_access()'s return, given it is no longer a void return > > function. > > > > Signed-off-by: Sergio Luis > > To: Casey Schaufler > > Cc: Ahmed S. Darwish > > Cc: LSM > > Cc: LKLM > > > > Acked-by: Casey Schaufler > Applied to: git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next I'll push this to Linus after he pulls the main security update, or with it on re-send. -- -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/