Date: Fri, 26 Dec 2008 10:18:22 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Wang Chen <wangchen@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Yinghai Lu <yinghai@kernel.org>,
       Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH 2/2 -tip] irq: kstat_incr_irqs_this_cpu only needs one
	parameter
Message-ID: <20081226091822.GE27747@elte.hu>
References: <4954A02E.3030207@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4954A02E.3030207@cn.fujitsu.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1411
Lines: 43


* Wang Chen <wangchen@cn.fujitsu.com> wrote:

> desc is useless for kstat_incr_irqs_this_cpu.
> 
> Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com>
> ---
>  arch/x86/kernel/visws_quirks.c |    2 +-
>  arch/x86/xen/spinlock.c        |    2 +-
>  include/linux/kernel_stat.h    |    3 +--
>  kernel/irq/chip.c              |   10 +++++-----
>  kernel/irq/handle.c            |    4 ++--
>  5 files changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/x86/kernel/visws_quirks.c b/arch/x86/kernel/visws_quirks.c
> index 0c9667f..bd37460 100644
> --- a/arch/x86/kernel/visws_quirks.c
> +++ b/arch/x86/kernel/visws_quirks.c
> @@ -633,7 +633,7 @@ static irqreturn_t piix4_master_intr(int irq, void *dev_id)
>  	/*
>  	 * handle this 'virtual interrupt' as a Cobalt one now.
>  	 */
> -	kstat_incr_irqs_this_cpu(realirq, desc);
> +	kstat_incr_irqs_this_cpu(realirq);
>  
>  	if (likely(desc->action != NULL))
>  		handle_IRQ_event(realirq, desc->action);

'desc' is needed in the sparseirq model:

#define kstat_incr_irqs_this_cpu(irqno, DESC) \
        ((DESC)->kstat_irqs[smp_processor_id()]++)

See:

 http://people.redhat.com/mingo/tip.git/README

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/