Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753965AbYLZNqt (ORCPT ); Fri, 26 Dec 2008 08:46:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753258AbYLZNqZ (ORCPT ); Fri, 26 Dec 2008 08:46:25 -0500 Received: from mail-bw0-f21.google.com ([209.85.218.21]:47186 "EHLO mail-bw0-f21.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753186AbYLZNqY (ORCPT ); Fri, 26 Dec 2008 08:46:24 -0500 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=date:to:cc:subject:message-id:reply-to:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent:from; b=MVtOyJ7Zt+XX/KBhDbz1N+KKPSXfLXHX2cmDeQ8rq7lES2V0QF9XVD6liMZKLpUgam SmETe9OOhtoQUF9doT1rdWAGBa+GPaAH9GUjgcLNZjFOQEa3YAQJTMzZjktz05EwmPOj LN9mN3K8soy7eyQxGxC4pTfN8Z08rHja3d/QQ= Date: Fri, 26 Dec 2008 14:46:21 +0100 To: Bartlomiej Zolnierkiewicz Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org Subject: Re: [PATCH 0/8] ide-cd: first conversion batch Message-ID: <20081226134621.GB23503@gollum.tnic> Reply-To: petkovbb@gmail.com Mail-Followup-To: petkovbb@gmail.com, Bartlomiej Zolnierkiewicz , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org References: <1229586052-3542-1-git-send-email-petkovbb@gmail.com> <200812192115.41068.bzolnier@gmail.com> <20081220062849.GA14770@gollum.tnic> <200812212005.56973.bzolnier@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200812212005.56973.bzolnier@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) From: Borislav Petkov Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1338 Lines: 45 From: Borislav Petkov Date: Thu, 25 Dec 2008 18:46:35 +0100 Subject: [PATCH 10/11] ide-cd: start DMA before sending the actual packet command as it is done for all other IDE ATAPI devices. There should be no functionality change resulting from this patch. Signed-off-by: Borislav Petkov --- drivers/ide/ide-cd.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c index 1c1ba43..2cb301d 100644 --- a/drivers/ide/ide-cd.c +++ b/drivers/ide/ide-cd.c @@ -593,13 +593,13 @@ static ide_startstop_t cdrom_transfer_packet_command(ide_drive_t *drive) if (cmd_len < ATAPI_MIN_CDB_BYTES) cmd_len = ATAPI_MIN_CDB_BYTES; - /* send the command to the device */ - hwif->tp_ops->output_data(drive, NULL, rq->cmd, cmd_len); - /* start the DMA if need be */ if (drive->dma) hwif->dma_ops->dma_start(drive); + /* send the command to the device */ + hwif->tp_ops->output_data(drive, NULL, rq->cmd, cmd_len); + return ide_started; } -- 1.6.0.4 -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/