Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754118AbYL0Ka6 (ORCPT ); Sat, 27 Dec 2008 05:30:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752750AbYL0Kat (ORCPT ); Sat, 27 Dec 2008 05:30:49 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:39728 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752649AbYL0Kas (ORCPT ); Sat, 27 Dec 2008 05:30:48 -0500 Date: Sat, 27 Dec 2008 11:30:36 +0100 From: Ingo Molnar To: Jaswinder Singh Cc: x86 maintainers , LKML Subject: Re: [PATCH] x86: apic.c x2apic_preenabled and disable_x2apic should be static Message-ID: <20081227103036.GE14639@elte.hu> References: <1230049353.14358.6.camel@jaswinder.satnam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1230049353.14358.6.camel@jaswinder.satnam> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 22 * Jaswinder Singh wrote: > Impact: cleanup, reduce kernel size a bit, avoid sparse warning > > Fixes sparse warning: > arch/x86/kernel/apic.c:103:5: warning: symbol 'disable_x2apic' was not declared. Should it be static? > > Signed-off-by: Jaswinder Singh > --- > arch/x86/include/asm/apic.h | 2 +- > arch/x86/kernel/apic.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) applied to tip/x86/cleanups, thanks! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/