Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754418AbYL0Kb6 (ORCPT ); Sat, 27 Dec 2008 05:31:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753271AbYL0Kbu (ORCPT ); Sat, 27 Dec 2008 05:31:50 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:49966 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752750AbYL0Kbt (ORCPT ); Sat, 27 Dec 2008 05:31:49 -0500 Date: Sat, 27 Dec 2008 11:31:41 +0100 From: Ingo Molnar To: Jaswinder Singh Cc: x86 maintainers , LKML Subject: Re: [PATCH] x86: reboot.c declare port_cf9_safe before they get used Message-ID: <20081227103141.GF14639@elte.hu> References: <1230049288.14358.4.camel@jaswinder.satnam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1230049288.14358.4.camel@jaswinder.satnam> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1037 Lines: 36 * Jaswinder Singh wrote: > Impact: cleanup, avoid sparse warning > > Include "../pci/pci.h" for port_cf9_safe > > Fixes this sparse warning: > arch/x86/kernel/reboot.c:43:6: warning: symbol 'port_cf9_safe' was not declared. Should it be static? > > Signed-off-by: Jaswinder Singh > --- > arch/x86/kernel/reboot.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) applied to tip/x86/cleanups, thanks! btw., this is ugly now: > --- a/arch/x86/kernel/reboot.c > +++ b/arch/x86/kernel/reboot.c > @@ -22,6 +22,7 @@ > #endif > > #include > +#include "../pci/pci.h" could you send another patch that moves arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h (and update all the pci.h include sites)? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/