Subject: Re: [PATCH] x86: reboot.c declare port_cf9_safe before they get
	used
From: Jaswinder Singh Rajput <jaswinder@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: x86 maintainers <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
In-Reply-To: <20081227103141.GF14639@elte.hu>
References: <1230049288.14358.4.camel@jaswinder.satnam>
	 <20081227103141.GF14639@elte.hu>
Content-Type: text/plain; charset=utf8
Date: Mon, 29 Dec 2008 14:13:18 +0530
Message-Id: <1230540199.3715.11.camel@jaswinder.satnam>
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1341
Lines: 48

Hello Ingo,

On Sat, 2008-12-27 at 11:31 +0100, Ingo Molnar wrote:

> btw., this is ugly now:
> 
> > --- a/arch/x86/kernel/reboot.c
> > +++ b/arch/x86/kernel/reboot.c
> > @@ -22,6 +22,7 @@
> >  #endif
> >  
> >  #include <mach_ipi.h>
> > +#include "../pci/pci.h"
> 
> could you send another patch that moves arch/x86/pci/pci.h to 
> arch/x86/include/asm/pci_x86.h (and update all the pci.h include sites)?
> 

1. I send ﻿[PATCH] move arch/x86/pci/pci.h to
arch/x86/include/asm/pci_x86.h but I forget to write x86: before this
patch.

Please let me know which one is better option :
﻿[PATCH]x86: move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h
OR
﻿﻿[PATCH -tip]x86: move arch/x86/pci/pci.h to
arch/x86/include/asm/pci_x86.h
OR some other name.

2. I also did not write any reason of patch this may lead confusion to
other developers, can you please provide some good reasons for this
patch.

3. I also did some cleanups in ﻿arch/x86/include/asm/pci_x86.h raised
by  ./scripts/checkpatch.pl, is this OK.

4. Can I resend above patch by solving above issues.

Thank you,

	JSR


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/