Date: Mon, 29 Dec 2008 11:07:46 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinder@infradead.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>, x86 maintainers <x86@kernel.org>,
       LKML <linux-kernel@vger.kernel.org>, mj@ucw.cz
Subject: Re: [PATCH] move arch/x86/pci/pci.h to
	arch/x86/include/asm/pci_x86.h
Message-ID: <20081229100746.GA12159@elte.hu>
References: <1230382948.3373.1.camel@jaswinder.satnam> <20081229065713.GA10960@x200.localdomain> <1230537538.3090.4.camel@jaswinder.satnam>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1230537538.3090.4.camel@jaswinder.satnam>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1137
Lines: 30


* Jaswinder Singh Rajput <jaswinder@infradead.org> wrote:

> On Mon, 2008-12-29 at 09:57 +0300, Alexey Dobriyan wrote:
> > On Sat, Dec 27, 2008 at 06:32:28PM +0530, Jaswinder Singh Rajput wrote:
> > > Impact: cleanup, arch/x86/pci/pci.h -> arch/x86/include/asm/pci_x86.h
> > 
> > And this is done for what?
> 
> Don't you think ﻿arch/x86/pci/pci.h looks ugly it should be in
> arch/x86/incluse/asm directory ?
> 
> It was suggested by Ingo :
> http://marc.info/?l=linux-kernel&m=123037395221921&w=2
> 
> I think Ingo will have more valid reasons to satisfy your curiousity ;-)

yes - the reason why i asked for that is that asm/pci.h already exists, 
and it is included in generic code (via linux/include/pci.h) and provides 
public PCI interfaces.

pci_x86.h (a'ka arch/x86/pci/pci.h) includes lowlevel x86-only internals, 
included from a handful PCI arch/x86/ platform .c files.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/