Date: Mon, 29 Dec 2008 12:08:55 +0100
From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinder@infradead.org>,
       Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: x86 maintainers <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: reboot.c declare port_cf9_safe before they get
	used
Message-ID: <20081229110855.GA5065@elte.hu>
References: <1230049288.14358.4.camel@jaswinder.satnam> <20081227103141.GF14639@elte.hu> <1230540199.3715.11.camel@jaswinder.satnam>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1230540199.3715.11.camel@jaswinder.satnam>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1193
Lines: 38


* Jaswinder Singh Rajput <jaswinder@infradead.org> wrote:

> Hello Ingo,
> 
> On Sat, 2008-12-27 at 11:31 +0100, Ingo Molnar wrote:
> 
> > btw., this is ugly now:
> > 
> > > --- a/arch/x86/kernel/reboot.c
> > > +++ b/arch/x86/kernel/reboot.c
> > > @@ -22,6 +22,7 @@
> > >  #endif
> > >  
> > >  #include <mach_ipi.h>
> > > +#include "../pci/pci.h"
> > 
> > could you send another patch that moves arch/x86/pci/pci.h to 
> > arch/x86/include/asm/pci_x86.h (and update all the pci.h include sites)?
> > 
> 
> 1. I send ﻿[PATCH] move arch/x86/pci/pci.h to
> arch/x86/include/asm/pci_x86.h but I forget to write x86: before this
> patch.

no, your patch is fine. I routinely fix up commit logs.

Jesse, is it fine to you if we push this via the x86 tree? A couple of 
usage sites of arch/x86/pci/pci.h arose that use ../pci/pci.h kind of ugly
#include prefixes, which justifies moving the file to
arch/x86/include/asm. No change in behavior.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/