Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755252AbYL2NBw (ORCPT ); Mon, 29 Dec 2008 08:01:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752475AbYL2NBo (ORCPT ); Mon, 29 Dec 2008 08:01:44 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:55357 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752051AbYL2NBn (ORCPT ); Mon, 29 Dec 2008 08:01:43 -0500 Date: Mon, 29 Dec 2008 14:01:33 +0100 From: Ingo Molnar To: Sam Ravnborg Cc: Jaswinder Singh Rajput , x86 maintainers , LKML , mj@ucw.cz Subject: Re: [PATCH] move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h Message-ID: <20081229130133.GA26634@elte.hu> References: <1230382948.3373.1.camel@jaswinder.satnam> <20081229121218.GB9628@elte.hu> <20081229122251.GA13687@elte.hu> <20081229125411.GA1852@uranus.ravnborg.org> <20081229125921.GB23674@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081229125921.GB23674@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3162 Lines: 76 * Ingo Molnar wrote: > > * Sam Ravnborg wrote: > > > > > > > btw., you missed to update a couple of places - pci/pci.h was used outside > > > of arch/x86 as well. Updated patch below. > > > > > > Ingo > > > > > > ----------------> > > > >From 54a090abe7cb85c724305124f57d2570b7e9adf1 Mon Sep 17 00:00:00 2001 > > > From: Jaswinder Singh Rajput > > > Date: Sat, 27 Dec 2008 18:32:28 +0530 > > > Subject: [PATCH] x86, pci: move arch/x86/pci/pci.h to arch/x86/include/asm/pci_x86.h > > > > > > Impact: cleanup > > > > > > Now that arch/x86/pci/pci.h is used in a number of other places as well, > > > move the lowlevel x86 pci definitions into the architecture include files. > > > (not to be confused with the existing arch/x86/include/asm/pci.h file, > > > which provides public details about x86 PCI) > > > > > > Tested on: X86_32_UP, X86_32_SMP and X86_64_SMP > > > > > > Signed-off-by: Jaswinder Singh Rajput > > > Signed-off-by: Ingo Molnar > > > --- > > > arch/x86/include/asm/pci_x86.h | 165 ++++++++++++++++++++++++++++++++++++ > > > arch/x86/kernel/mmconf-fam10h_64.c | 3 +- > > > arch/x86/kernel/reboot.c | 3 +- > > > arch/x86/pci/acpi.c | 2 +- > > > arch/x86/pci/amd_bus.c | 2 +- > > > arch/x86/pci/common.c | 3 +- > > > arch/x86/pci/direct.c | 2 +- > > > arch/x86/pci/early.c | 2 +- > > > arch/x86/pci/fixup.c | 3 +- > > > arch/x86/pci/i386.c | 2 +- > > > arch/x86/pci/init.c | 2 +- > > > arch/x86/pci/irq.c | 3 +- > > > arch/x86/pci/legacy.c | 2 +- > > > arch/x86/pci/mmconfig-shared.c | 3 +- > > > arch/x86/pci/mmconfig_32.c | 2 +- > > > arch/x86/pci/mmconfig_64.c | 3 +- > > > arch/x86/pci/numaq_32.c | 2 +- > > > arch/x86/pci/olpc.c | 2 +- > > > arch/x86/pci/pcbios.c | 5 +- > > > arch/x86/pci/pci.h | 162 ----------------------------------- > > > arch/x86/pci/visws.c | 3 +- > > > drivers/pci/hotplug/cpqphp_core.c | 2 +- > > > drivers/pci/hotplug/cpqphp_pci.c | 2 +- > > > drivers/pci/hotplug/ibmphp_core.c | 2 +- > > > 24 files changed, 188 insertions(+), 194 deletions(-) > > > > You should teach your script to use: > > git format-patch -M -B -C > > > > With -M -B -C you get a much better picture of what happens when you > > rename files like in this patch (and copy them). > > you mean: > > git format-patch --stdout -1 -M -B -C also, this does not result in a patch that will be applied properly by the usual patch-tools that people use when they pick up patches from email. So i'll just keep my old script ;-) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/